supabase / storage / 38556984248

86%

push

github

fix: keep version files when deleting a null-version object (#1507)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

File backend versions live at key/version so the null-version path is a
directory. Delete uses recursive rm and removes every version under that
key.

## What is the new behavior?

Unlink the exact path. Remove an empty directory so the key can be
uploaded
again, and leave a directory that still has children. 

Mac and windows report a directory as EPERM. Ignore that only when
`lstat` shows a directory,
and treat a path that disappears before the check as already gone.

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>

7640 of 9476 branches covered (80.62%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 1 file covered. (100.0%)

13319 of 15074 relevant lines covered (88.36%)

855.75 hits per line