polserver / polserver / 38576502995

82%

Build Type

push

github

Committed by web-flow

Commit Message

Bound the proxy header and Huffman output to their buffers (#987)

A proxy-protocol v2 header from an AllowProxy address was read into
the 2560-byte receive buffer at whatever payload size it announced,
up to 16 + 65535 bytes. It is now refused and the client
disconnected when the payload exceeds the buffer. Type-length-value
records after the address block still fit.

transmit_encrypted Huffman-coded into a 65535-byte buffer and checked
the end only afterwards. At up to 11 bits per byte, any packet over
about 57 KB of high-entropy data (zlib 0xDD gumps, 0xD8 house
designs) wrote past it. The output is now sized from the code lengths
and sent in pieces of at most 0xFFFF bytes. Client::transmit refuses
packets longer than 0xFFFF bytes.

The 0xD8 builder wrote each plane header before its bounds check and
sent designs over 0xFFFF bytes with a truncated length. It now checks
before writing and does not send such a design.

Testing: testnetwork.cpp round-trips huffman_compress through a
decoder, including 65535 bytes of 11-bit codes, and drives a Client
through an oversized proxy header and one with TLV records.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

38 of 47 new or added lines in 3 files covered. (80.85%)

16 existing lines in 6 files now uncovered.

60315 of 73560 relevant lines covered (81.99%)

1049488.25 hits per line