polserver / polserver / 36265725291

82%

Build Type

push

github

Committed by web-flow

Commit Message

Give items in a trade window and corpse copies a slot of their own (#980)

With UseContainerSlots, two call sites filed an item under the slot it
arrived with. In both cases that slot was 0.

An item offered into a secure trade window is extricated from its
container on the way, so its slot_index() is 0. The window filed every
offered item under that slot. do_place_item_in_secure_trade_container
now moves the item in with Items::move_into, which takes a free slot.

The copies a corpse takes of hair and of items the body cannot drop are
fresh clones, which carry no slot. Character::die() now passes them
through can_add_to_slot, as it already does for the worn items it moves
onto the corpse.

Three FIXMEs in dropitem.cpp asking for this check go with it.

Testing: trade_items_take_free_slots and corpse_copies_take_free_slots,
both seen failing without the fix.

Co-authored-by: murderinc <3738856+murderinc@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

7 existing lines in 3 files now uncovered.

60265 of 73547 relevant lines covered (81.94%)

600456.04 hits per line