ponder-lab / Hybridize-Functions-Refactoring / #3434

89%

push

github

Follow numpy and static-shape taint into closures (#1065)

* Follow numpy and static-shape taint into closures

A nested function reads an enclosing function's parameter lexically
rather than receiving it as an argument, so the numpy-on-parameters
taint and the static-shape-read walk both stopped at a lambda or a
nested def. Both now follow it. A tainted value the enclosing function
publishes with a lexical write taints the variable, identified by its
name and defining scope; lexical reads of it inherit the taint; and
every function nested in that scope that the body calls is scanned with
the lexical taint, since it need not receive any tainted argument.

A comprehension is not covered yet: the front end emits no lexical
write for the enclosing names a comprehension reads
(https://github.com/wala/ML/issues/1066). Its cases are pinned at
today's result with TODOs.

Fixes #1061.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Scan closures that the enclosing body does not call itself

A nested function can run within the enclosing function's trace without
the body calling it: a helper that calls a lambda it is passed, for
example. The nested pass scanned only the functions the body calls, so
such a closure's numpy call or static read went unseen. It now also
scans every call-graph node nested in a tainted variable's defining
scope, wherever it is called from; with no call site in the body, its
result colors nothing.

A callback that tf.map_fn runs is not covered yet, because the summary
never invokes it, so it has no call-graph node
(https://github.com/wala/ML/issues/942). Those cases are pinned at
today's result with TODOs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Look up nested functions by type name instead of scanning the graph

Finding the functions nested in a tainted scope w... (continued)

148 of 159 new or added lines in 3 files covered. (93.08%)

4989 of 5656 relevant lines covered (88.21%)

0.88 hits per line