stacklok / toolhive / 38547203870

71%

Build Type

push

github

Committed by web-flow

Commit Message

Merge commit from fork

* Restrict telemetry environment variable entries

Treat telemetry environment variable entries strictly as host variable
names. Drop entries that are not valid names before they are used for
span attributes, and omit the list from Config.String() output.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Stop env-var entries at the first assignment

Splitting an otel.env-vars entry on commas before filtering NAME=value
pieces left the tail of a header value, such as "SECRETTAIL" in
"OTEL_EXPORTER_OTLP_HEADERS=Authorization=Bearer abc,SECRETTAIL", as a
bare name that was exported as a span attribute name.

Keep the pieces before the first assignment and drop the rest of the
entry. In the span middleware, skip any name containing '=' instead of
the strict identifier check, which silently dropped legitimate names
such as my-var and ProgramFiles(x86). Move the mockSpan doc comment
back above its type.

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Jakub Hrozek <jakub.hrozek@posteo.se>
Co-authored-by: Radoslav Dimitrov <radoslav@stacklok.com>

Coverage Stats

10 of 10 new or added lines in 3 files covered. (100.0%)

43 existing lines in 7 files now uncovered.

86275 of 121111 relevant lines covered (71.24%)

126.61 hits per line