node-opcua / node-opcua / 38541969436

91%

Build Type

push

github

Committed by erossignon

Commit Message

fix(address-space): sibling functions keep their own FunctionalGroup members

Two functions of one type declared side by side (OPC 30500 LADS sensors in
one FunctionSet) shadow the same originals of their function type.
reconstructFunctionalGroupType took the first clone of the flat list, so each
function's Operational also organized its siblings' SensorValue, CurrentValue
and CurrentState (the modeler's DSL-E-DI-003 check now rejects such models).

CloneHelper now records every clone of an original, and the pass picks the
FunctionalGroup clone nearest to the organized clone in the instance. The
duplicate guard compared NodeIds with ===; it uses sameNodeId.

Coverage Stats

34369 of 42155 branches covered (81.53%)

64 of 64 new or added lines in 1 file covered. (100.0%)

127 existing lines in 8 files now uncovered.

229202 of 250838 relevant lines covered (91.37%)

224749.47 hits per line