stacklok / toolhive / 38445460461

71%

push

github

Skip undecodable items in Modern list responses (#6772)

* Skip undecodable items in Modern list responses

A single tools/list item the compat types cannot decode, such as a tool
whose top-level inputSchema "type" is a JSON Schema type array, failed
the whole page. The backend then listed no tools at all, so nothing
downstream could use or manage its other tools.

Decode list items one at a time and skip an item that fails, logging a
warning that names it. A list field that is not an array still fails the
page.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Name the backend when skipping list items

The skip warning had no backend identity, unlike the neighbouring list
warnings, so with several backends it was hard to trace which one served
the malformed item. Thread the backend name into modernListAll.

Also skip JSON null items, which previously decoded into a zero-value
item and were kept, and cover resources, prompts and null items in a
single table-driven test. The undecodable fixture is now a wrongly typed
field rather than a schema type array, so it stays undecodable once
toolhive-core accepts type arrays.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Address review feedback on list item skipping

Reword the modernListAll comment so a skip no longer reads as a spec
violation by the backend. The compat types model less than the spec
allows (an outputSchema type array is valid), so a skip means vMCP could
not use the item.

Decode name and uri separately when naming a skipped item, so a wrongly
typed name no longer blanks out a usable uri.

Cover a bad resource template, a page where every item is bad, and a bad
item followed by a further page, and add a direct itemIdentifier test.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

27 of 27 new or added lines in 1 file covered. (100.0%)

86297 of 121065 relevant lines covered (71.28%)

126.55 hits per line