solidjs / solid / 38436644418

78%

main: 89%

push

github

fix(compiler): nullish checkbox/radio value removes the attribute in non-hydratable builds (#4017) (#4021)

Both compilers inlined the #2957 text-field fallback (`el.value = v ?? ""`)
for value/defaultValue on every input, so a client-only build never reached
the #4009 runtime path and a checked checkbox with a nullish value submitted
"" instead of "on".

When an <input>'s static `type` is checkbox or radio (case-insensitive), or
its type cannot be resolved at compile time (expression, prop:type,
attr:type), a non-literal value/defaultValue now compiles to the existing
`setProperty` runtime helper, which already tests the live type. Inputs with
no type or another static type, and textareas, keep the inline `?? ""`.


Claude-Session: https://claude.ai/code/session_01NcUAu8BQ6Xsf8XRBhr9V1w

Co-authored-by: Claude <noreply@anthropic.com>

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

1079 of 1321 relevant lines covered (81.68%)

27.16 hits per line