urwid / urwid / 38368952571

90%

push

github

Log and survive exceptions raised by alarm callbacks (#1418)

* Log and survive exceptions raised by alarm callbacks

A callback registered through set_alarm_in/set_alarm_at with the
wrong signature (or one that raises for any other reason) let the
exception escape run(), tearing down the whole application with a
traceback pointing at urwid internals rather than the offending
callback.

Wrap the alarm callback in _make_alarm_callback: exceptions are
logged with their traceback naming the callback, and the loop keeps
running. ExitMainLoop is re-raised so alarms can still exit the
loop, and the async def variant is wrapped identically. The
set_alarm_in/set_alarm_at docstrings now document the behavior.

Fixes #1269

Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>

* Spell out the alarm callback signature in the set_alarm_in docstring

Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>

---------

Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>

4760 of 5524 branches covered (86.17%)

Branch coverage included in aggregate %.

10 of 12 new or added lines in 1 file covered. (83.33%)

12017 of 13294 relevant lines covered (90.39%)

14.26 hits per line