iotaledger / iota / 38332579516

72%

Build Type

push

github

Committed by web-flow

Commit Message

chore: bump Rust toolchain to 1.99 and fix new lints (#13154)

# Description of change

Bumps the pinned Rust toolchain from 1.98 to 1.99 and fixes the errors
surfaced by the new compiler, clippy and rustdoc.

Lints raised inside dependency macros, fixed by newer releases of those
dependencies (lockfile only, except typed-store's `uint`
dev-dependency):

- `clippy::double_must_use` from `#[async_trait]` and
`#[async_recursion]`: async-trait 0.1.89 -> 0.1.92, async-recursion
1.1.1 -> 1.2.0.
- `semicolon_in_expressions_from_non_local_macros` from `eyre::bail!`
(expanded by the `DBMapUtils` derive), insta's snapshot macros and
`uint::construct_uint!`: eyre 0.6.12 -> 0.6.14, insta 1.42.2 -> 1.49.0,
uint 0.9.5 -> 0.10.2 (typed-store's `uint` dev-dependency moves from
`"0.9"` to `"0.10"`).
- `clippy::redundant_field_names` from diesel's
`#[derive(QueryableByName)]`
([diesel#5152](https://github.com/diesel-rs/diesel/issues/5152)): diesel
2.3.10 -> 2.3.13, diesel_derives 2.3.9 -> 2.3.10.

`cargo update` for insta and diesel also changed which version three
crates use of a dependency that the lockfile holds in several versions
(bip39: rand_core 0.6.4 -> 0.5.1; prost-build and snafu-derive: heck
0.5.0 -> 0.4.1). Those are reverted to their previous versions.

Lints in our code:

- `clippy::block_scrutinee` in the IOTA conservation check of
`execution_engine.rs`: drop the block around the scrutinee (same
expression; in edition 2021 the temporaries were already dropped after
the `if let`).
- Deprecated `AtomicU32::fetch_update` in starfish admission: renamed to
`try_update`.
- `clippy::clone_on_copy` in iota-indexer and the iota-sdk examples.
- `rustdoc::redundant_explicit_links` in the gRPC transaction execution
service docs.
- Unused deprecated `std::u64` import in move-vm-test-utils.

## Links to any relevant issues

None.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [ ] Patch-specific tests... (continued)

Coverage Stats

2 of 19 new or added lines in 3 files covered. (10.53%)

272 existing lines in 32 files now uncovered.

187941 of 265912 relevant lines covered (70.68%)

451077.71 hits per line