MushroomObserver / mushroom-observer / 38328055876

99%

main: 99%

Pull #5492

github

Finish the stateful-link keep/edit toggle; fix create-button visibility

Merges the location autocompleter's separate keep-btn/edit-btn into
one Button using active_icon:/active_content:, finishing the
unwired .stateful-link mechanism (Components::Button::Content) --
map_controller.js#toggleBoxLock now toggles a single "active" class
instead of juggling d-none across two elements, and
tooltip_controller.js keeps the cached Bootstrap tooltip title in
sync with that same class via a generic data-active-title watcher.

placeRectangle now syncs the toggle's "active" state right after the
rectangle draws, not only on click -- a rectangle can draw already
locked (e.g. the observation form's reference box for an already-
matched location), and the toggle needs to start correct, not just
catch up after the first click.

Also fixes "+ New Locality" showing for an exact match on an
existing location: `.create-button { display: none }` tied in
specificity with multiple .btn-family rules (.btn itself, and
.btn:has(.mo-icon) for icon-centering) and lost on source order --
the keep/edit toggle's visibility hit the same bug, fixed the same
way: d-none (!important), driven directly by cssHasIdOrNo alongside
the existing has-id/offer-create classes.

Renamed the shared Stimulus target keepBtn -> keepOrEditBtn now that
it represents both states, and fixed a dangling reference to the
deleted editBtn target in swap() left over from the merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

24 of 24 new or added lines in 6 files covered. (100.0%)

59134 of 59452 relevant lines covered (99.47%)

898.37 hits per line