archetech / archon / 38324690599

95%

main: 93%

Build Type

Pull #1389

github

Committed by macterra

Commit Message

fix(keymaster): report Gatekeeper timeouts as 504 and outages as 503

A Gatekeeper request that timed out in the Python Keymaster raised
httpx.ReadTimeout, whose message is empty, so callers got a 500 with
{"error": ""} and the log got two tracebacks. The TypeScript Keymaster set
no Gatekeeper timeout and waited indefinitely, and its resolve-style routes
reported any failure, including an outage, as 404.

Both Gatekeeper clients now raise GatekeeperTimeoutError when no response
arrives in time and GatekeeperUnavailableError when Gatekeeper cannot be
reached. Both services map them to 504 and 503 with a message, and the
TypeScript service uses the same 30-second timeout as Python. Resolve-style
routes keep their 404 for resolution failures but pass these through.
The Python generic handler no longer logs a traceback Starlette already
logs. README section 16.3 records the classification.

Fixes #1380

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #1389: fix(keymaster): report Gatekeeper timeouts as 504 and outages as 503

Coverage Stats

3579 of 3996 branches covered (89.56%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 7 files covered. (100.0%)

1 existing line in 1 file now uncovered.

9865 of 10153 relevant lines covered (97.16%)

22043.92 hits per line