coreui / coreui-pro / 38295280748

96%

main: 94%

push

github

fix(Button): take the font weight from the shared button and input frame (#1625)

Fields, input group addons and the search button read their weight from
--cui-btn-input-font-weight on :root, which defaults to
--cui-body-font-weight, but .btn hardcoded --cui-btn-font-weight to the
normal weight. Setting either token on :root changed the field next to a
button and left the button behind, while padding, height, font size, line
height, border and radius already moved both.

--cui-btn-font-weight now reads --cui-btn-input-font-weight. With nothing
retuned the chain still ends at the normal weight, so the default rendering
is unchanged; a lighter body weight on :root now makes buttons lighter along
with the fields, and .btn-link keeps the normal weight. Like the other frame
tokens, the weight resolves on :root: a subtree retunes it through
--cui-btn-input-font-weight or --cui-btn-font-weight.

The migration guide gets its own entry for $btn-font-weight, which was
removed without one and was never a forwarder of the frame, and the forms
overview says which frame tokens buttons share with fields (size and type)
and which belong to fields only (the colors).

A visual spec puts a button in an input group next to a field and an addon,
with a search button and a link button beside it, and retunes the frame
weight and then the body weight on :root. Both cases fail on the button with
the old declaration, and the body case fails when the frame stops following
the body weight.

7681 of 8269 branches covered (92.89%)

Branch coverage included in aggregate %.

13291 of 13590 relevant lines covered (97.8%)

1715.71 hits per line