aio-libs / multidict / 38284156973

86%

push

github

Fold the entry fill helpers into _md_store_new_entry() (#1786)

<!-- Thank you for your contribution! -->

## What do these changes do?

Folds `_md_fill_str_entry()` and `_md_fill_anystr_entry()` into
`_md_store_new_entry()`, their only caller, which already branches on
the table kind. Their comments move to the function's header. C
extension only; the pure-Python backend has no such helpers.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes two helpers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Callgrind on 3.14.7, base `2933772c` against this branch: every row
identical on both GIL and FT (0.0% on all 124 rows each).

Drafted with Claude Code (Claude Opus 5.5); review by @asvetlov pending.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` on 3.11.13 with `MULTIDICT_DEBUG_BUILD=1`, 4274
passed; 3.14.7t, 4255 passed; pure Python on 3.11.13 with
`MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions`, 1697 passed.
Inlining: `tools/check_inlining.py` on 3.14.7 and 3.14.7t, all rules ok.
Spelling: `make doc-spelling`, build succeeded.
Benchmarks: `benchmarks/callgrind_driver.py --include-multidict-only`;
the measured tree differed from the pushed commit only in a comment.
</details>

842 of 1684 branches covered (50.0%)

Branch coverage included in aggregate %.

9799 of 10709 relevant lines covered (91.5%)

1.83 hits per line