safe-global / safe-client-gateway / 38271941207

91%

push

github

fix(tests): stop signature, chain ID and JWT test flakes (#3572)

* fix(tests): stop signature, chain ID, JWT and migrator lock flakes

- Verifier specs built the "invalid" signature from the last byte of the
  original one. For contract signatures that is random dynamic-part data, so
  a 00 byte re-parsed it as a contract signature without a dynamic part.
  Corrupt one hex digit of r instead, like the verifyConfirmation case.
- safe-signature r/s/v specs used a random 65-byte hex whose last byte could
  be 00 (contract signature). Draw a non-zero v.
- recipient-analysis: faker.string.numeric's `exclude` filters characters, not
  values, so the target chain ID could equal the source. Redraw on collision.
- notifications v2: faker.string.sample() can contain two dots, which
  jsonwebtoken reports as "invalid token" rather than "jwt malformed".
- DatabaseMigrator: CREATE TABLE IF NOT EXISTS and the check-then-insert lock
  are not atomic, so parallel boots on a fresh database could fail with
  pg_class_relname_nsp_index. Serialise both under a transaction-scoped
  advisory lock.

Refs WA-1753

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: move the migrator lock fix to its own PR

The DatabaseMigrator change is production code and is reviewed
separately; this branch keeps the test-only fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

4635 of 5392 branches covered (85.96%)

Branch coverage included in aggregate %.

11742 of 12787 relevant lines covered (91.83%)

367.21 hits per line