aio-libs / multidict / 38245285389

86%

push

github

Fold single-caller helpers into their callers (#1779)

<!-- Thank you for your contribution! -->

## What do these changes do?

Folds three C helpers that each had one caller into that caller:
`_md_del_at()` into `_md_pop_one_locked()`, `_md_add_identity()` into
`md_add()` and `_md_add_for_upd_steal_refs()` into `md_add_for_upd()`.
The comment on why references are dropped only after the entry is
unlinked moves to `_md_unlink_at()`. The `_md_del_at` rule in
`tools/check_inlining.py` goes with the function. Also drops the inner
`hash == -1` check in `unicode_hash()`, which returned the same `-1` the
function returns anyway.

The C extension only; the pure-Python backend has no equivalent.

Callgrind, 3.14.7, `MultiDict` and `CIMultiDict`, against the merge
base:
on GIL `pop()` needs 1.05% fewer instructions (398.2 to 394.0); no other
row moves by 0.1% or more on either build.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes code.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change; covered
by the existing suite)
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` on 3.11.13, C extension 4262 passed, pure Python
(`MULTIDICT_NO_EXTENSIONS=1`, `--no-c-extensions`) 1692 passed.
Inlining: `tools/check_inlining.py` on 3.14.7 and 3.14.7t, ok.
Codegen: `tools/codegen_diff.py` against 3fe4fbff; FT changes only
`md_add` and `md_add_for_upd`; GIL reshuffles 136 functions after the
`md_add_for_upd` fold, with no measured row moving except `pop()`.
Docs: `make... (continued)

832 of 1664 branches covered (50.0%)

Branch coverage included in aggregate %.

9763 of 10652 relevant lines covered (91.65%)

1.83 hits per line