urwid / urwid / 38241190178

90%

push

github

Lint: update checkers and widen the rule selection (#1414)

Bump the static checkers and select the recommended checks that were
missing, fixing what they report.

- Remove pylint suppressions that pylint 4.1.3 reports as useless.
- Select DTZ and BLE, so the existing DTZ005 and BLE001 suppressions are used.
- Select RSE and drop redundant parentheses on raised exception classes.
- Load pylint docparams and document the missing parameters.
- Remove a stray expand_tabs entry from Edit.set_mask's docstring.
- Load pylint redefined_variable_type:
  - Padding and Overlay convert width and height into new normalized_*
    variables instead of overwriting the parameters, which drops 3
    type: ignore[arg-type] comments.
  - Mark 5 variables with a declared union type as false positives.
- Fix the standalone refurb findings in canvas.py and vterm.py.

| what | from | to |
| --- | --- | --- |
| ruff (pre-commit rev) | v0.16.9 | v0.17.0 |
| pyproject-fmt (pre-commit rev) | v2.30.1 | v2.30.3 |
| pylint (pylint-requirements.txt) | 4.1.2 | 4.1.3 |
| ruff extend-select | - | BLE, DTZ, RSE |
| pylint load-plugins | - | docparams, redefined_variable_type |

4721 of 5494 branches covered (85.93%)

Branch coverage included in aggregate %.

49 of 52 new or added lines in 12 files covered. (94.23%)

11933 of 13214 relevant lines covered (90.31%)

10.9 hits per line