solidjs / solid / 38237987341

78%

main: 89%

push

github

fix(diagnostics): browser bridge keeps shared references in its payload (#3967)

`toSerializable` tracked every object it had written in one `seen` set, so
a reference that appeared twice was dropped as if it were a cycle. A
`LONG_HOLD` diagnostic carries the hold's own `blockers` and
`acknowledgements` arrays in its `data`, and diagnostics are serialized
before `attribution.holds`, so the transferred hold record lost both and
`expectNoSilentHolds` threw a `TypeError` in `isSilent` on any browser
capture with a long hold. The replacer now tracks only the ancestors of
the value being written: a shared reference is written again, and only an
object that contains itself is dropped.

Fixes #3960

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

1079 of 1321 relevant lines covered (81.68%)

27.07 hits per line