solidjs / solid / 38237980590

78%

main: 89%

push

github

fix(compiler): keep component refs behind TypeScript casts (#3970)

* fix(compiler): keep component refs behind TypeScript casts (#3968)

The component ref branch classified the raw expression, so a
`TSAsExpression`, `TSNonNullExpression` or `TSSatisfiesExpression`
matched no ref shape and `assignment_fallback` returned `None`, which
dropped the prop with no diagnostic. The Babel plugin strips those
wrappers first; the shared and universal ref lowerings now do the same.
The universal lowering also keeps an array ref, which Babel passes
through as a plain property.

* fix: address review findings

The universal element ref lowering now strips `as` and `!` before
classifying the target, the same two wrappers Babel's universal
element transform strips, so `<view ref={myRef as any} />` emits the
`myRef = _el$` fallback instead of leaving the cast in the output. The
cast refs test matches the generated `_ref$` name by pattern instead of
the hard-coded `_ref$3`, and covers the element path for the dom and
universal generates. The changeset names only the cast-wrapped refs and
the universal element fix; conditional and logical refs are still
dropped, as in Babel. The `unwrap_ts_ref_value` doc comment is one line.

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

1079 of 1321 relevant lines covered (81.68%)

27.07 hits per line