kyma-project / busola / 38227099828

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Recover gracefully from a stopped login after session expiry (#5357)

* fix: stop a single session expiry from tripping the OIDC loop guard (#5307)

A real session expiry fires several reauth handlers in one page load, each
registering a redirect, so the redirect-loop guard trips on the very first
expiry. Count at most one reauth redirect per page load via a module-level
claim; genuine bounce loops still count because each bounce is a fresh load.

* fix: release the reauth claim when the redirect never leaves the page (#5307)

The per-load claim was only released when the redirect rejected. A page
restored from the bfcache (Back from the IdP) or a cancelled navigation kept
it held, so every later re-auth silently did nothing. The claim now expires
after half the loop window and is released on a persisted pageshow.

* fix: make the login-stopped dialog recoverable (#5307)

When the redirect-loop guard trips, the terminal dialog was a dead end that
dumped the user at the cluster list. Retry now forces a fresh IdP sign-in
(prompt=login) and returns the user to where they were:

- re-persist the active cluster before the redirect so the IdP callback can
  restore it and finish the login instead of orphaning the code exchange;
- preserve the kubeconfigID marker on the saved path so a pending
  restricted-market deep-link still defers to the correct cluster.

* fix: save the return path only on Retry and read it at call time (#5307)

- A path saved when the dialog opened was restored on whichever cluster the
  user opened next after closing it; save it on Retry instead.
- The SSO Retry read the URL after the app had moved to the cluster list.
- useReauthenticate saved the page that was open when the cluster logged in,
  because useAuthHandler keeps the callback across navigations.
- Keep the identity provider hint in the dialog text.

* fix: keep silent renew attached after login and end the re-auth loops (#5307)

Found by running the flows against a r... (continued)

Coverage Stats

2688 of 12322 branches covered (21.81%)

Branch coverage included in aggregate %.

38 of 47 new or added lines in 5 files covered. (80.85%)

6 existing lines in 3 files now uncovered.

5285 of 17205 relevant lines covered (30.72%)

26.22 hits per line