eclipse-aascw / aas-core-codegen / 38221506508
90%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 309
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.142% (+0.001%) from 90.141%
38221506508

push

github

web-flow 
Unify JSON error paths across targets (#845)

The targets reported different paths for the same JSON de-serialization
error. For example, C++ wrote ``.someItems`` where the others wrote
``someItems``, Python wrote the keys of JSON-able objects as
``['a b']`` while the others wrote ``["a b"]``, and C++ wrote them as
properties, ``.a b``. We now report the same path in all six targets:

* The path starts with the first property without a dot, *e.g.*,
  ``items[0].name``.
* A key is always written as a JSON string in brackets, *e.g.*,
  ``values["a b"][1]``, escaped as ``JSON.stringify`` does, so that
  the control characters without a short escape become ``\u00XX``.
* A property name which is no identifier is written in brackets as
  well, *e.g.*, ``["$eq"]``, as C# and Java already did.
* An unexpected property is reported at the object which holds it,
  while Python reported it at the unexpected property itself.
* A missing, unknown or wrong model type is reported at the instance,
  *e.g.*, ``tricky[1]``, and a model type which is not a string at
  the property, ``tricky[1].modelType``, as the type errors of all
  the other properties are.

Python now refuses a ``modelType`` on a class which carries none, as
the other targets do, instead of silently accepting it.

We add live test data for a model type which is not a string, and
update the checked-in C++ recordings of ``json_types``.

45274 of 50225 relevant lines covered (90.14%)

2.7 hits per line

Coverage Regressions

Lines Coverage ∆ File
28
96.61
0.02% aas_core_codegen/cpp/lib/_generate_jsonization.py
23
96.13
0.0% aas_core_codegen/csharp/lib/_generate_jsonization.py
21
96.7
0.0% aas_core_codegen/java/lib/_generate_jsonization.py
19
96.46
0.0% aas_core_codegen/golang/lib/_generate_jsonization.py
15
97.0
0.0% aas_core_codegen/typescript/lib/_generate_jsonization.py
12
96.93
0.02% aas_core_codegen/python/lib/_generate_jsonization.py
Jobs
ID Job ID Ran Files Coverage
1 3.12 - 38221506508.1 309
90.14
GitHub Action Run
2 3.11 - 38221506508.2 309
90.14
GitHub Action Run
3 3.10 - 38221506508.3 309
90.14
GitHub Action Run
Source Files on build 38221506508