FlexMeasures / flexmeasures / 38220679989

88%

push

github

perf: validate storage constraints without DataFrame.eval (#2641)

* perf: validate storage constraints without DataFrame.eval

Eleven eval calls per device, about 2.5 ms each, on every schedule preparation.

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* refactor: drop validate_constraint and sanitize_expression

Nothing in production called them after the vectorisation; their code lives on as the
reference implementation in the tests.

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* docs/changelog: link PR #2641 in the storage schedule entry

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>

* test: request market prices in every planning test that schedules against them

The db fixture is module-scoped,
so these 14 tests only found the epex_da prices because an earlier test in the same module had requested add_market_prices.
Run on their own, or as a -k subset, they failed with UnknownPricesException (or an empty price frame).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019R1KifG9DB7p9bGjtRh3u1
Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: Stijn van Houwelingen <teadrinkingprogrammer@proton.me>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

36 of 36 new or added lines in 1 file covered. (100.0%)

21404 of 24707 relevant lines covered (86.63%)

0.87 hits per line