grpc
/
grpc-java
/
#20519
89%
master: 89%
master: 89%
|
Ran
|
Jobs
1
|
Files
687
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 89.178% (+0.007%) from 89.171%
push
github
web-flowRevert "core: Delayed deserialization for unary/server-streaming calls (#13004) (v1.84.x backport) (#13110) Backport of #13107 to v1.84.x. --- This reverts commit 8ba4b4872 because this change breaks grpc-kotlin tests that use InProcessTransport by causing a deadlock because [ServerCalls.kt](https://github.com/grpc/grpc-kotlin/blob/master/stub/src/main/java/io/grpc/kotlin/ServerCalls.kt#L214-L215) only requests the next message after `onMessage` delivers the current one, and messages get queued because the client hasn't called `halfClose` yet. When the client halfCloses, `InProcessTransport.halfClose` [defers](https://github.com/grpc/grpc-java/blob/master/inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java#L904) delivering halfClose if the server's receive queue is non-empty. **Resulting Deadlock:** - `ServerCallImpl` waits for `halfClosed()` before dispatching Message 1. - `InProcessTransport` waits for `call.request(1)` before dispatching `halfClosed()`. - The server waits for Message 1 before calling `call.request(1)`. - The test hangs indefinitely waiting for `closeStatus.await()` until the 10s test timeout expires. There are a few other failures too but those can be fixed in the test code alone. Internal Test failures: http://shortn/_If0NinnwQ4
38367 of 43023 relevant lines covered (89.18%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 4 |
91.2
|
-0.88% | ../core/src/main/java/io/grpc/internal/MessageDeframer.java |
| 2 |
92.95
|
-0.67% | ../core/src/main/java/io/grpc/internal/GrpcUtil.java |
| 2 |
96.27
|
0.64% | ../core/src/main/java/io/grpc/internal/ServerCallImpl.java |
| 2 |
93.07
|
-0.14% | ../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java |
| 1 |
75.25
|
-0.99% | ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20519.1 | 687 |
89.18
|
