IJHack / QtPass / 38206226267

93%

push

github

Executor: start child processes without a controlling terminal (#2016)

Started from a terminal, QtPass's children inherited it: git asked for HTTPS credentials, and ssh for a passphrase or a host key, on that /dev/tty. The executor runs one command at a time, so every decrypt and save waited behind a prompt nobody was looking at, and QtPass looked frozen (reproduced with a pty and no askpass helper). Every child now starts in a new session (QProcess::UnixProcessFlag::CreateNewSession, Qt 6.7+, Unix): git and ssh use SSH_ASKPASS/GIT_ASKPASS when set and fail at once with an error QtPass shows otherwise. Applied in Executor::startProcess (queued and blocking paths, including callers that pass their own QProcess) and to qrencode, the one process started elsewhere.

gpg is unaffected (pinentry comes from gpg-agent, via GPG_TTY or the tty on gpg's stdin, here a pipe); GIT_TERMINAL_PROMPT is deliberately not set, as some credential helpers read it as no interaction at all.


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

6 of 6 new or added lines in 2 files covered. (100.0%)

9141 of 9843 relevant lines covered (92.87%)

193.01 hits per line