astronomer / astro-cli / 38187870570

61%

main: 45%

push

github

Accept a pasted connection JSON at the env set prompt (#2299)

* Accept a pasted connection JSON at the env set prompt

The value prompt read with term.ReadPassword, which uses the terminal's
line mode. Pretty-printed JSON ended at its first newline and arrived as
a lone "{", and macOS caps a line in that mode at 1024 bytes and drops
the rest, Enter included, so a pasted service-account key left the
prompt hanging.

input.HiddenValue reads in raw mode instead. Enter ends the value except
inside a JSON object or array that is still open, so a multi-line paste
ends where the JSON does, and Ctrl-D ends it anywhere.

Co-Authored-By: Claude <noreply@anthropic.com>

* Tell a paste from typing with bracketed paste

Review follow-ups for the hidden value prompt:

- The open-JSON rule swallowed Enter for any value starting with an
  unclosed { or [, a password included, and did nothing for a non-JSON
  multi-line paste such as a PEM key, whose later lines ran as shell
  commands. The prompt now turns on bracketed paste: newlines inside a
  paste are part of the value, a typed Enter ends it, and a paste ending
  in a newline ends it as pasting a line always has.
- Ctrl-C exited 1. cliout.ExitCode now maps input.ErrInterrupted to 130.
- input.Password, behind the cloud env prompt and APC auth, still used
  term.ReadPassword and had the same paste bugs. It uses HiddenValue.
- Reads are one byte at a time, so nothing past the value is taken off
  the terminal and lost.
- ESC O sequences (function keys, application-mode arrows) are skipped,
  and a bare Esc no longer eats the key after it.
- SIGTERM and SIGHUP put the terminal back before exiting, so a killed
  prompt does not leave the shell without echo.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

104 of 145 new or added lines in 4 files covered. (71.72%)

40175 of 69602 relevant lines covered (57.72%)

233.71 hits per line