ossia / libossia / 38174210013

53%

Build Type

push

github

Committed by jcelerier

Commit Message

osc: a receiver on port 0 knows its port and stops without freeing its socket under the thread

A receiver bound to port 0 kept port() == 0. stop() woke its thread by
sending a packet to 127.0.0.1:0, which macOS refuses to connect to; the
exception made it detach the thread and free the socket, the thread's
select() then failed and run_impl() retried Run() on the null socket.
Every test of score that closes a document segfaulted that way on macOS.

- setPort() records the port the system picked;
- stop() breaks the loop through the multiplexer's pipe whether or not the
  wake-up packet is sent, and never frees the socket of a thread it could
  not join;
- run_impl() retries only while the receiver is running.

OSCReceiverTest fails before (port() == 0) and passes after on Linux; the
OSC, OSC UDP and OSCQuery tests still pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JeL19ofVgPe9u9q7J1V9ex

Coverage Stats

37 of 46 new or added lines in 2 files covered. (80.43%)

4 existing lines in 2 files now uncovered.

32385 of 61446 relevant lines covered (52.7%)

209308.9 hits per line