aio-libs / multidict / 38173811595

86%

push

github

Fold the compact entry identity and hash helpers into their callers (#1773)

<!-- Thank you for your contribution! -->

## What do these changes do?

`compact_entry_identity_cs()`/`_ci()` and
`compact_entry_hash_cs()`/`_ci()` only forwarded `entry->key` to
`compact_key_identity_*()` and `compact_key_hash_*()`. The four wrappers
are removed and their callers call the key helpers directly, keeping the
per-class `_cs`/`_ci` split. C extension only; the pure-Python backend
has no table kinds.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes four helpers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests (C extension): 3.10.17 4260 passed, 178 skipped. Pure-Python leg
(3.10.17, `MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions`): 1692 passed,
22 skipped.
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t; the
`PyIter_NextItem` note is the same on master.
Codegen (`tools/codegen_diff.py` against the merge base): GIL 6 of 358
functions differ, FT 61 of 369, all with unchanged instruction counts
and call targets. The only size changes are FT `_md_to_dict_locked` (+9
bytes) and `_md_pop_all_locked` (-4 bytes), from register allocation;
the rest are shifted relocations.
Docs: `make doc-spelling` passed.
</details>

832 of 1664 branches covered (50.0%)

Branch coverage included in aggregate %.

9757 of 10641 relevant lines covered (91.69%)

1.83 hits per line