romshark / icumsg / 38141687490

98%

push

github

fix: Accept doubles and selectordinal offsets

Accept any double value as an explicit value or offset, including one
with a leading zero, and accept an offset in a selectordinal:

    {n, plural, =1.5{a} =-1{b} =01{c} other{d}}

    Before: ErrExpectBracketOpen at byte 14
    After:  no error

    {n, selectordinal, offset:1 one{#st} other{#th}}

    Before: ErrInvalidOption at byte 19
    After:  no error

In the pluralStyle syntax of [ICU4C PluralFormat], explicit values and
offsets are numbers, which [ICU4C ChoiceFormat] defines as double
values in unlocalized ASCII. The grammar in [ICU4C MessageFormat] rules
out leading zeros only in argument numbers, and it gives selectordinal
the same pluralStyle as plural, so parse both with consumePluralArg.

[ICU4C PluralFormat] selects the explicit value that equals the number
it formats, so report options with equal values as duplicates, however
they're written:

    {n, plural, =1{a} =1.0{b} other{c}}

    Before: ErrExpectBracketOpen at byte 20
    After:  ErrDuplicateOption at byte 18

Argument types stay lowercase, as the grammar in [ICU4C MessageFormat]
writes them.

55 of 55 new or added lines in 1 file covered. (100.0%)

1749 of 1791 relevant lines covered (97.65%)

957.53 hits per line