petl-developers / petl / 38112667599

94%

Build Type

push

github

Committed by web-flow

Commit Message

Fix progress UnboundLocalError on tables without rows (#738)

This PR has the objective of fixing `progress()` and `log_progress()` on
a table that yields no rows at all, not even a header.

This happens, for example, when reading an empty CSV file.
`ProgressViewBase.__iter__` uses the loop variable `n` after the loop to
build the final message, but `n` is never assigned when the loop body
doesn't run:

```python
>>> import petl as etl
>>> list(etl.fromcsv('empty.csv').progress())
UnboundLocalError: cannot access local variable 'n' where it is not associated with a value
```

`n` now starts at 0, so the final message reports `0 rows in ...` and
iteration ends normally.

Co-authored-by: Juarez Rudsatz <juarezr@gmail.com>

Coverage Stats

9 of 9 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

15387 of 16616 relevant lines covered (92.6%)

0.93 hits per line