supabase / supabase-swift / 38047074857

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest): jsonObject returns JSONValue and JSON comparisons encode their operand (#1501)

jsonObject(_:) kept the receiver's Value, and a JSONValue operand went out in
PostgREST filter form. So jsonObject("a").eq("1") sent eq.1, which PostgREST
reads as the number 1: the filter matched the wrong rows. .string("x") and
.null were 22P02 errors.

jsonObject(_:) now returns a JSONValue expression, which is what -> produces.
PostgrestFilterValue gains a _typedOperand requirement that defaults to
rawValue; JSONValue implements it with the JSON encoding. The typed filters
send _typedOperand, in eq, neq, gt, gte, lt, lte, isDistinct and in; the
untyped builder keeps rawValue.

A value with no wire form (a non-finite JSONValue.double) has a nil
_typedOperand. The filter then carries an .invalid operand, and execute()
throws PostgrestError(kind: .invalidRequest) before the request is built, as
containsJSON already does. No stand-in operand is sent: eq.null matches
JSON-null rows.

Refs SDK-2207

Coverage Stats

26 of 26 new or added lines in 5 files covered. (100.0%)

11 existing lines in 3 files now uncovered.

12510 of 13702 relevant lines covered (91.3%)

71.15 hits per line