safe-global / safe-client-gateway / 37947305979

91%

push

github

build: resolve #/ imports natively and type-check specs on TS 7 (#3551)

* build: resolve #/ imports natively and type-check specs on TS 7

Replace the tsconfig `paths` alias (`@/`) with package.json subpath imports (`#/`), so Node resolves them at runtime and `tsc-alias` is dropped from the build. TypeScript and Vitest pick the sources through a `source` condition; Node uses the compiled `dist` output.

`#/` subpath imports need Node >= 24.14, so Node moves to 24.21.0 (Docker image on alpine3.24, `.nvmrc`, CI) with `engines` set accordingly; the production stage now ships `package.json` for the imports map.

Add `yarn typecheck` (tsc over tsconfig.json, specs and scripts included) and run it in CI in place of the source-only check, after fixing the 104 spec type errors it surfaced. VS Code is pointed at the TypeScript 7 language server.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* build: address #/ imports review feedback

- Add a `types` condition to every `#/` entry in the package.json `imports` map so Biome resolves to TypeScript sources instead of the untyped `dist` output, restoring cross-module type-aware rules (`noFloatingPromises`, `noMisusedPromises`, `noDeprecatedImports`) on `#/` imports.
- Reduce the Vitest conditions to `['source']` (Vitest merges its own defaults) and drop the direct `vite` devDependency.
- Correct the biome-job type-check comment: the build already type-checks `src` and `scripts`; this job adds specs, `__tests__` helpers and `test/`.
- List `yarn typecheck` wherever guides restate the pre-commit checklist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* retrigger

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

4664 of 5424 branches covered (85.99%)

Branch coverage included in aggregate %.

11799 of 12859 relevant lines covered (91.76%)

552.66 hits per line