kobotoolbox / kpi / 37943572708

84%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(processing): stop deleted transcripts reappearing in data table DEV-3068 (#7684)

### 📣 Summary

Deleting a transcript now removes it from the data table and exports for
good.

### 📖 Description

When a question had been transcribed both automatically and manually,
deleting the transcript could make an older automatic version reappear
in the data table and in exports. The deleted transcript now stays
deleted everywhere. The same fix applies to translations.

### 💭 Notes

- The `_supplementalDetails` output picks the most recent result per
column across NLP actions. A deletion made its action drop out of that
comparison instead of winning it, so an older accepted result from the
other action came back.
- Deletions now compete by date as an internal `_deleted` marker, and
when one wins the column is left out. Translations
(`attach_action_dependency`), bulk eligibility
(`_has_existing_transcription`) and the processing view already treat a
newer deletion this way.
- This restores the DEV-1601 behavior (#6619). #7182 started returning
`{}` for deletions and changed
`test_simplified_supplemental_detail_for_delete` to expect the older
automatic transcript; this PR changes that assertion back.

### 👀 Preview steps

1. ℹ️ have a project with an audio question, a submission, and both
automatic and manual transcription enabled
2. accept an automatic transcript, then save a manual transcript on top
of it
3. delete the transcript in the processing view
4. open the project's data table
5. 🔴 [on main] the old automatic transcript shows up in the transcript
column
6. 🟢 [on PR] the transcript column is empty

Coverage Stats

10500 of 13868 branches covered (75.71%)

2 of 21 new or added lines in 3 files covered. (9.52%)

4 existing lines in 2 files now uncovered.

33480 of 40280 relevant lines covered (83.12%)

5.49 hits per line