wol-soft / php-json-schema-model-generator / 37926708088

99%

master: 99%

Pull #192

github

Accept filters in nested allOf object branches and widen conditional-only properties to mixed

Filters in nested compositions of an allOf branch:
branchContainsFilter() descended into nested compositions of a branch before
the nested level had inherited the object type of its parent, so the untyped
"then" of a conditional in an object-typed allOf branch was taken for a scalar
branch and the filter on its object property was rejected. The same schema
without the allOf wrapper was accepted. The recursion is removed: every
nested composition builds its own branch property and runs the check on its
own branches after its own type inheritance, so a filter in a scalar
composition is still rejected at every depth (the message now names the
innermost composition). Passing the inherited object-ness down manually was
rejected as it would duplicate the inheritance rules.

A composition below "properties" of a string-typed branch is no longer
inspected; such properties can never apply to a string, so the filter can
never run.

TypeError for conditional-only properties:
a property declared only in the then (or only in the else) of an
if/then/else kept a typed slot although the missing branch constrains
nothing and a value of any type is valid while the declaring branch is
inactive. Reading it threw a TypeError from the getter, and for a conditional
nested in an allOf branch the constructor threw it. A conditional with only
one branch is now treated like a composition with an implicit unconstrained
branch, so the property is widened to mixed as documented for properties
exclusive to a single branch. A property which is also declared at the root
keeps its type. This changes the generated accessors of then-only/else-only
properties from ?T to mixed.

Updates the documentation of the filter rule, the then-only type hint and
the widening rule.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y7cwkHFG9yLwdmxU9pPrbR

4 of 4 new or added lines in 1 file covered. (100.0%)

7940 of 8029 relevant lines covered (98.89%)

598.42 hits per line