akvo / akvo-mis / #1433

91%

push

coveralls-python

Feature/535 iwsims sync approval tab and mobile changes (#536)

* [#535] Stop pending submissions showing as batches in the Pending Approval tab

Ported from iwsims #89 (akvo/iwsims af6525bf).

- Load the pending data list in one query instead of one per row:
  select_related created_by/administration/form/parent, compute
  answer_history with an Exists subquery, and reuse the paginator's count
- Ignore stale form-pending-data responses on the frontend so a slow reply
  for a previous tab/page can't render pending rows as batches with no
  approvers (Submissions and Control Center PanelSubmissions)
- Clear the table and total when the tab or form changes
- Tests: query count does not grow per row; serializer answer_history
  without the annotation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* [#535] Fix file permissions for uploaded files to ensure nginx can serve them

Changed storage.upload() to use shutil.copyfile() instead of copy2() and explicitly set file permissions to 0o644. This prevents issues where temporary files created with restrictive permissions (0o600) would cause nginx to return 403 errors when attempting to serve the uploaded files. The explicit chmod also ensures correct permissions when overwriting existing files.
https://github.com/akvo/iwsims/commit/d8e1c9039

* [#535] Say why Submit is blocked and fix the question-group completion tick

Ported from iwsims #86 (akvo/iwsims de716212), plus the completion-tick fix.

- On a blocked Submit, open the first section with a problem, close the group
  list, and show the field errors there
- Keep "complete all required fields" only for missing answers; a filled but
  invalid answer gets its own toast naming the section, question and reason
- Give number fields a readable type error for input like "2,5"
- Capitalise the leading "this" in inline field errors
- Drive the question-group complet... (continued)

8698 of 9814 branches covered (88.63%)

Branch coverage included in aggregate %.

15788 of 17168 relevant lines covered (91.96%)

0.92 hits per line