akvo / akvo-mis / #1427

91%

main: 91%

Pull #536

coveralls-python

[#535] Say why Submit is blocked and fix the question-group completion tick

Ported from iwsims #86 (akvo/iwsims de716212), plus the completion-tick fix.

- On a blocked Submit, open the first section with a problem, close the group
  list, and show the field errors there
- Keep "complete all required fields" only for missing answers; a filled but
  invalid answer gets its own toast naming the section, question and reason
- Give number fields a readable type error for input like "2,5"
- Capitalise the leading "this" in inline field errors
- Drive the question-group completion tick from validity, not just presence:
  countValidRequiredQuestions now returns groupsValid, so a group holding a
  filled-but-invalid answer (e.g. a non-numeric phone number) is no longer
  ticked green. Removes the presence-only checkCompleteQuestionGroup and
  checkGroupHasErrors
- Tests updated for the async groupsValid path, plus Submit tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

8698 of 9814 branches covered (88.63%)

Branch coverage included in aggregate %.

15787 of 17167 relevant lines covered (91.96%)

0.92 hits per line