37886396196
93%

Ran 09 Oct 2026 05:12AM UTC

Jobs 11

Files 1783

Run time 4min

Badge

Embed ▾

Committed 09 Oct 2026 04:58AM UTC coverage: 92.926% (+0.001%) from 92.925%

Build # 37886396196

Build Type

push

github

Committed by

web-flow

Commit Message

Warn when a local process execution sandbox cannot be deleted (#23696)

## Problem

`AsyncDropSandbox::drop` deletes a local sandbox by dropping its
`TempDir`, and `tempfile`'s `Drop` ignores any removal error. A sandbox
that contains a read-only directory is therefore left behind in the
temporary directory with no message. #23636 is one case: an extracted Go
module cache leaked about 700 sandboxes and 2.1 GB per cold run, and
nothing reported it. @tdyas asked there for at least a warning.

## Fix

Close the `TempDir` explicitly on the blocking cleanup task and log a
warning with the sandbox path when that fails. Behavior is otherwise
unchanged: cleanup still runs in the background and a failure does not
fail the run.

## Verification

Two unit tests in `local_tests.rs`: a normal sandbox is deleted, and a
sandbox with a read-only subdirectory returns an error that names its
path. End to end, a cold `check` of a Go module on main (without #23636)
now logs the warning for every leaked download sandbox.

Notice: Claude used for code drafting, tests and verification.

Coverage Stats

96032 of 103342 relevant lines covered (92.93%)

3.66 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	test_python_linux_x86_64_0/10 - 37886396196.1	09 Oct 2026 05:20AM UTC	1236	57.47	GitHub Action Run
2	test_python_linux_x86_64_7/10 - 37886396196.2	09 Oct 2026 05:21AM UTC	1219	50.87	GitHub Action Run
3	test_python_linux_x86_64_8/10 - 37886396196.3	09 Oct 2026 05:21AM UTC	1214	52.73	GitHub Action Run
4	test_python_linux_x86_64_4/10 - 37886396196.4	09 Oct 2026 05:21AM UTC	1245	59.04	GitHub Action Run
5	test_python_linux_x86_64_2/10 - 37886396196.5	09 Oct 2026 05:15AM UTC	1215	58.6	GitHub Action Run
6	test_python_linux_x86_64_1/10 - 37886396196.6	09 Oct 2026 05:17AM UTC	1215	48.88	GitHub Action Run
7	test_python_linux_x86_64_6/10 - 37886396196.7	09 Oct 2026 05:16AM UTC	1212	50.04	GitHub Action Run
8	test_python_linux_x86_64_3/10 - 37886396196.8	09 Oct 2026 05:18AM UTC	1214	52.36	GitHub Action Run
9	test_python_linux_x86_64_5/10 - 37886396196.9	09 Oct 2026 05:16AM UTC	1230	60.35	GitHub Action Run
10	test_python_linux_x86_64_9/10 - 37886396196.10	09 Oct 2026 05:16AM UTC	1225	54.01	GitHub Action Run
11	test_python_linux_arm64 - 37886396196.11	09 Oct 2026 05:12AM UTC	1196	52.66	GitHub Action Run

pantsbuild / pants / 37886396196
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37886396196

pantsbuild / pants / 37886396196 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37886396196

pantsbuild / pants / 37886396196
93%

README BADGES
x