solidjs / solid / 37855750222

77%

main: 89%

push

github

hydration: gather hydratable nodes once per adoption, not per occurrence (#3916)

* frames: announcement-gated slot/region scans; one TreeWalker pass for collectSlots

The adopt-time slot walk reads the server's tier announcement for the
SCAN, not only the load: a page whose `sc:tiers` record names other tiers
and not `bind` is never scanned for binding-slot markers (`_s:*`,
`<!--_s:t=…-->`) and never loads the bind tier for it; the un-announced
page (no record) keeps detection; a started load (`X-Frame-Tiers`,
`chunk.tiers`) is itself an announcement. The record is read at each walk,
so a later data script's cumulative re-write naming `bind` is seen by the
boundary adopting after it. Regions were already content-gated — pinned.

`collectSlots` is one TreeWalker pass by `whatToShow`: comments, plus
elements only when markers may exist; a comment's data is tested by prefix
before any regex; a range's interior is skipped by stepping the walker to
its end marker; a nested frame is stepped over whole (elements shown) or
excluded by a per-start ancestry test (comments only). Same slots, same
order, same records; a truncated range still abandons its sibling list.

HN story page (652 occurrences, 16.9k comments, Chromium): `collectSlots`
14.23 → 5.35 ms inclusive. Frames eager +333 B minified / +152 B brotli —
over the scenario's cap and the pass's 20 B allowance; measured variants
and the slot-index design note in documentation/plans/frames-hydration-walk.md.

Pins: consistency/tier-bind-announced-gate.spec (3); bench
test/frames-hydration-walk.bench.ts.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* size: raise frames/page caps for the announcement-gated scans + one-pass TreeWalker collectSlots (maintainer Size-Exception, perf)

Only the seven over-cap scenarios, each to CI's measured brotli + 10 B at
the 0.01 KB step (Size run 37756065705 against next @ 8d23a5a13) with the
minified recorded from the sam... (continued)

676 of 960 branches covered (70.42%)

Branch coverage included in aggregate %.

996 of 1227 relevant lines covered (81.17%)

28.59 hits per line