bleedingdeacons / fellowship / 37849980255
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.439% (-0.5%) from 90.93%
37849980255

push

github

web-flow 
feat: use the Guardian library for OAuth sign-in (#39)

The four providers, the ID-token verifier and the provider registry move
to bleedingdeacons/guardian, which Reach already bundles (reach#123). The
two copies had drifted; the JWKS refresh floor reached this one only in
#38.

- Guardian ^1.0 is required through a vcs repository, loaded from
  fellowship.php, and shipped in the production zip's staged vendor/.
- VerifiedIdentity stays Fellowship's own type, because Freedom's audience
  contract carries it. A provider's answer is converted with
  VerifiedIdentity::fromProvider() at the browser callback and at the
  Apple ID-token exchange, so nothing an audience sees changes.
- Fellowship\Auth\ProviderRegistry is now an empty, deprecated subclass of
  Guardian's: Freedom's tests still build the broker with it, and
  IdentityBroker and DeviceAuthController take Guardian's, which it is.
- StateStore is a thin wrapper over Guardian's, keeping its signatures and
  its fellowship_oauth_state_ prefix, so a sign-in in flight across the
  upgrade still completes.
- Settings implements Guardian's CredentialStore; stored credentials do
  not move.
- The settings page renders and saves the provider rows through Guardian's
  ProviderCredentialsSection. The form fields are renamed in the process:
  google_client_id is now client_id_google, and so on.
- JWKS key sets are now cached as guardian_jwks_*, shared with Reach.

The provider, verifier, refresh-floor and token-refusal tests moved to
Guardian; the three refusals Guardian lacked were ported in guardian#2.

3131 of 3462 relevant lines covered (90.44%)

7.19 hits per line

Coverage Regressions

Lines Coverage ∆ File
8
91.23
-3.87% fellowship/fellowship/src/Admin/SettingsPage.php
8
16.67
-66.67% fellowship/fellowship/src/Auth/Base64Url.php
8
96.67
0.01% fellowship/fellowship/src/Rest/DeviceAuthController.php
5
89.04
0.0% fellowship/fellowship/src/Core/Settings.php
3
89.8
0.0% fellowship/fellowship/src/Auth/IdentityBroker.php
3
33.33
-41.67% fellowship/fellowship/src/Auth/VerifiedIdentity.php
Jobs
ID Job ID Ran Files Coverage
1 37849980255.1 59
90.44
GitHub Action Run
Source Files on build 37849980255