lonnieezell / Bonfire2 / 37848134273

57%

push

github

refactor(#585): declare the Recycler protocol and give Logs a LogStore (#592)

* refactor(#585): give Logs a LogStore behind its controller

LogStore lists, reads, counts and deletes log files by validated name
(log-YYYY-MM-DD), so LogsController shrinks to authorization plus response.

Fixes: the controller now requires logs.view / logs.manage, level counts
count entries instead of every occurrence of a level name, the parser no
longer iterates a null, and the page comes from the request instead of $_GET.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* refactor(#585): declare the Recycler protocol and let modules register resources

Models customize the Recycler through CustomRecyclerQuery, CustomRecyclerRestore
and CustomRecyclerPurge instead of method_exists(). RecyclableResource holds the
defaults in one place, using the model's own primary key and soft delete field,
and refuses to restore or purge a record that is not deleted. Modules register
resources with service('recycler')->register(); Config\Recycler still adds or
overrides them. The controller's repeated permission/lookup preamble is one method.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

146 of 147 new or added lines in 7 files covered. (99.32%)

1912 of 3448 relevant lines covered (55.45%)

26.19 hits per line