lonnieezell / Bonfire2 / 37839356080

57%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#584): give widgets one owner for enabled, dashboard and settings (#590)

* tests(#584): pin widget settings, chart script and dashboard behaviour

Characterise what the Widgets module does today, through the settings
controller, ChartsItem::getScript() and the dashboard cells, so the
deepening in the next commit can be checked against it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* refactor(#584): give widgets one owner for enabled, dashboard and settings

Add ItemSettings (an item's enabled flag and the names it is stored and
posted under), DashboardContext (is this the dashboard, and does this item
show; reached through service('dashboardContext') so tests can inject it
instead of faking current_url()) and WidgetOptions (Stats and per-chart-type
display options as data, driving save, reset and ChartsItem::getScript).

StatsItem, ChartsItem, Users/Module, the cell views, the settings view and
the settings controller ask them instead of building 'Stats.<Kind>_<id>' and
comparing current_url() by hand. Manager::items() replaces manager(), so
items of every collection are listed, not only the first. The Stats.* keys
stored in installs' databases are unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* refactor(#584): simplify WidgetOptions and drop unused settings view params

Derive WidgetOptions' custom options from its type instead of passing them
in, share the save line between both loops, and look options up without
rebuilding the name list. Stop passing the unread 'widgets' variable to the
settings views.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* docs(#584): mark widget ownership change as breaking and complete the test example

Item gained settings(), Manager::manager() became items() and the protected
$dashboardRoute properties are gone, so the changelog entry carries the
breaking-change marker.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-b... (continued)

Coverage Stats

74 of 75 new or added lines in 9 files covered. (98.67%)

2 existing lines in 2 files now uncovered.

1828 of 3437 relevant lines covered (53.19%)

22.85 hits per line