kobotoolbox / kpi / 37826658694

83%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(attachments): stop storage counters from drifting and going negative DEV-3015 (#7680)

### 📣 Summary
Storage usage no longer goes below zero or drifts away from the files
actually stored.

### 📖 Description
Some accounts showed a negative storage usage, which gave them more room
than their plan allows. Others counted more or less than what they
really store. This happened when files were deleted, restored, or moved
to the trash at the same time as other changes, when a submission was
edited, when a project was emptied from the trash, or when a project was
transferred to another user. Storage usage is now always computed from
the projects themselves, and every change counts each file exactly once,
even when several happen at the same time.

### 👷 Description for instance maintainers
- The weekly `sync-storage-counters` task is removed, and a migration
deletes it from the Celery Beat schedule. It compared the user profile
counter with the sum of the user's projects; that profile counter is not
updated anymore, so the task would have found every profile out of sync
and suspended submissions while recounting them.
- Do not run `update_attachment_storage_bytes` (directly, or through
`soft_delete_orphan_attachments_2_023_37c_fix`) until the follow-up PR,
which rewrites it: the current version still resets and recounts
profiles, with submissions suspended.
- Counters that are already wrong are not repaired here. A follow-up PR
adds a long-running migration that recounts them.

Coverage Stats

10361 of 13680 branches covered (75.74%)

64 of 135 new or added lines in 15 files covered. (47.41%)

2775 existing lines in 85 files now uncovered.

33083 of 39812 relevant lines covered (83.1%)

5.5 hits per line