FlexMeasures / flexmeasures / 37808312698

87%

push

github

Check a forecast cycle's results against its automation's sensors (#2699)

* data/services: check a forecast cycle against its automation's sensors

Context:
- #2697: schedules, reports and plugin automation types are held to the
  sensors their automation was checked against, but a forecast cycle job
  saved without that check. Not a hole today, since a forecast automation is
  pinned to TrainPredictPipeline, which records only on sensor_to_save, but a
  gap in the contract #2694 builds on.

Change:
- run_forecast_cycle checks the cycle's results right after computing them,
  before anything is exported, saved or handed back, raising
  GeneratorWritesUncheckedSensor for a sensor outside the automation's set.
- The cycle jobs already carry the trigger meta, so no queueing changes. A
  direct run has no permitted set and is not checked, as for the others.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* data/tests: pin a forecast cycle refused for an unchecked sensor

Context:
- #2697.

Change:
- A forecast automation's cycle job, run on a worker with the forecasting
  handler, saves its beliefs when its sensor is among the automation's
  output sensors, and fails with GeneratorWritesUncheckedSensor, saving
  nothing, when it is not. The computation is stubbed, as the check between
  computing and saving is what is under test. On main, the refusal case
  fails: the job finishes and saves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* changelog: forecast cycle jobs are checked against their automation's sensors

Context:
- #2697.

Change:
- Infrastructure entry for #2699.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* data/services: read a forecast cycle's check as one call

Context:
- Review of #2699: the comment above the check pointed past several imports
  to the call... (continued)

7 of 7 new or added lines in 2 files covered. (100.0%)

21264 of 24567 relevant lines covered (86.56%)

0.87 hits per line