kobotoolbox / kpi / 37787188177

84%

master: 76%

push

github

feat(auth): allauth views in router DEV-1859 (#7644)

### 💭 Notes

Every allauth view we use now has a route. The ones without a screen yet
point at a shared placeholder, so the flows can be clicked through while
the real screens land one issue at a time. All of it sits behind the
`authRedesignEnabled` feature flag.

Anonymous views stay under `/auth/*`, authenticated ones are new under
`/account/*` as per Linear task guidelines.

Changes here:

- `router/routerConstants.ts`
- anonymous leaf paths renamed to allauth's own — `register` → `signup`,
`activate/:key` → `confirm-email/:key`, `reset-password` →
`password/reset` — so each route reads like the view it stands for. The
old ones were flag-only, so nothing in the wild breaks.
- new `ACCOUNT_AUTH_ROUTES` for the logged-in half; kept apart from
`ACCOUNT_ROUTES`
- `auth/routes.tsx` — the anonymous group, plus placeholders for the
one-time code, recovery code and SSO-signup steps
- `auth/accountRoutes.tsx` — new, 12 placeholders (email, password,
providers, sessions, 2FA, reauthentication) behind the flag and
`RequireAuth`
- `auth/AuthPlaceholderRoute/` — one placeholder reused everywhere; it
prints the matched path, which is the only thing keeping a dozen
identical twins tellable apart
- `router/router.tsx` — mounts the new group
- `*.stories.tsx` — path renames only, no behaviour
- `/auth/confirm-email/:key` is not where the sign up email points yet —
that is still the Django view. Aiming it here is DEV-1860.
- `/account/password/change` overlaps the live
`/account/change-password` - we will need to retire the old path when
dropping the flag
- skipped from allauth's demo router, since we don't have them switched
on: passkeys/WebAuthn, login-by-code, trusted devices, and the SPA
provider callback (our SSO uses allauth's server-side redirect)

### 👀 Preview steps

1. ℹ️ have an account
2. turn the flag on by visiting a path with
`?ff_authRedesignEnabled=true`
3. go to `/#/auth/signup` — 🟢 the redesign... (continued)

10499 of 13862 branches covered (75.74%)

33483 of 40277 relevant lines covered (83.13%)

5.49 hits per line