Eyevinn / hi264 / 37782312547

88%

Build Type

push

github

Committed by tobbee

Commit Message

refactor(hi264-mp4-extend): observe the input samples with ObserveAVCCSample

The tool reassembled every input sample as Annex-B, on a copy because avc.ConvertSampleToByteStream rewrites the length prefixes in place, only to hand the result to PSkipExtender.ObserveAnnexB, and then read the samples a second time to copy them to the output. ObserveAVCCSample takes the samples as they are, so one pass now both observes and collects them. The init segment's parameter sets are observed as NAL units. The output is byte-identical on testdata/seg1s.m4s for -frames 25, -frames 5 -black-idr and -frames 300.

Coverage Stats

9 of 13 new or added lines in 1 file covered. (69.23%)

78 existing lines in 3 files now uncovered.

8475 of 9620 relevant lines covered (88.1%)

1.02 hits per line