aio-libs / multidict / 37782018466

86%

push

github

Prefix header-local helpers with an underscore (#1753)

<!-- Thank you for your contribution! -->

## What do these changes do?

Applies the `_multilib` naming rule from AGENTS.md: a helper used only
inside its own header gets a leading underscore (`_bitmap_move`,
`_bitmap_next`, `_md_fresh_kind`, `_md_next_kind`,
`_removed_pairs_init`, `_removed_pairs_release`, `_md_entries_capacity`,
and `GROWTH_RATE` became `_growth_rate`, since `_G...` is a reserved
identifier), and `_md_del_at_deferred` loses its underscore because
`bulk_update.h` calls it.

`_str_cached_hash()` had a single caller, the one-line wrapper
`compact_key_hash_cs()`, so its body moved there. The unused
`as_const_anystr()` is removed. `_md_dump()` stays, as it is meant to be
called from a debugger.

Type slots, method callbacks and the capsule's `MultiDict_*` table
entries keep their names. The pure-Python backend is unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it is a rename inside private headers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change; the
existing suite covers it
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, C extension, 3.14: 4198 passed, 182 skipped
Tests, C extension, 3.10: 4202 passed, 178 skipped
Tests, pure Python (`MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions`),
3.14: 1664 passed, 24 skipped
`tools/check_inlining.py` on 3.14 and 3.14t: ok
`make doc-spelling`: passed
</details>

825 of 1650 branches covered (50.0%)

Branch coverage included in aggregate %.

9667 of 10547 relevant lines covered (91.66%)

1.83 hits per line