aio-libs / multidict / 37781906785

86%

push

github

Move istr_canonical() into istr_object.h (#1754)

<!-- Thank you for your contribution! -->

## What do these changes do?

Moves `istr_canonical()` from `htkeys.h` to `istr_object.h`, next to the
`istrobject` struct it reads, and uses it in `identity.h` in place of
the three direct `((istrobject*)key)->canonical` reads. The only
remaining direct accesses are in `istr.h`, where the field is set and
released. C extension only; the pure-Python backend has no equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it is a header reshuffle with no code generation change expected.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change;
covered by the existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, C extension: `pytest -q` on 3.14.7 (4198 passed, 182 skipped) and
3.10.17 (4202 passed, 178 skipped)
Tests, pure Python: `MULTIDICT_NO_EXTENSIONS=1 pytest -q
--no-c-extensions` on 3.14.7 (1664 passed, 24 skipped)
Inlining: `tools/check_inlining.py` on 3.14.7 and 3.14.7t, ok (12 and 16
rules)
Docs: `make doc-spelling`, build succeeded
</details>

825 of 1650 branches covered (50.0%)

Branch coverage included in aggregate %.

9667 of 10547 relevant lines covered (91.66%)

1.83 hits per line