kobotoolbox / kpi / 37774755613

86%

master: 76%

push

github

feat(auth): reset password form DEV-1852 (#7636)

### 📣 Summary

The redesigned sign-in screens can now recover a forgotten password: ask
for a reset link by email, then pick a new password from the link in
that email.

### 💭 Notes

Stacked on `leszek/dev-1851-login-form`, so review that one first.

Changes here:
- `ResetPasswordRoute/` — asks for an address, then replaces the form
with "Email has been sent"
- `NewPasswordRoute/` — with outcome panels per ending: changed, changed
and signed in, dead link, already logged in, and a lookup that failed on
network grounds
- `authValidation.ts` — email, password and confirm-password checks
moved out of `registerValidation.ts`
- `routes.tsx`, `routerConstants.ts` — two new routes, and the login
form's "Forgot password?" now stays in the app instead of jumping to the
Django page.
- Story helpers: `authStoryHelpers.tsx` plus `makeAuthConfigurationMock`
in `environment.mocks.ts`, collecting what five auth story files each
redeclared.

### 👀 Preview steps

1. ℹ️ have an account with a real email address, a way to read the mail
your instance sends, and a signed-out browser (the reset link refuses to
work behind a session)
2. open `/#/auth/login?ff_authRedesignEnabled=true` — the screens are
behind that flag, which then sticks for the tab
3. click "Forgot password?"
4. 🔴 [on base branch] you land on the old Django reset page
5. 🟢 [on PR] you land on "Reset your password" in the same card
6. submit it empty, then with something like `caroline@kbtdev` — 🟢 both
are refused without a request going out
7. enter your address, press "Reset password" — 🟢 "Email has been sent",
with no hint whether that address exists
8. in the email, copy the key out of the link
(`…/accounts/password/reset/key/<this-bit>/`) and open
`/#/auth/reset-password/<this-bit>`
9. 🟢 "Create new password" with two password fields
10. type two different passwords — 🟢 "You must type the same password
each time."
11. type one password twice, press "Cha... (continued)

10491 of 13858 branches covered (75.7%)

33461 of 40263 relevant lines covered (83.11%)

5.49 hits per line