nats-io / nats-server / 37729528973
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.191% (+2.2%) from 78.002%
37729528973

push

github

web-flow 
[FIXED] Leafnode interest and request/reply across account imports (#8730)

Fixes #8733 

A leaf with solicited remotes and no cluster block takes its cluster
name from server_name. The hub tags subscriptions from its links with
that cluster as the origin, and the origin was wrongly applied to
interest and messages that crossed an account import. With one link per
account on the same leaf, a subscriber in an importing account never had
its interest sent to the other account's link, and requests and replies
between the two were dropped as cluster echoes, producing "503 No
Responders".

- Clear the origin on stream import shadow subscriptions in
addShadowSub.
- Drop the leaf origin for messages imported from a service, including
in the route header.
- Let imported messages go back to their origin leaf cluster, which
never saw them in the importing account.

Tests cover interest and request/reply on the same leaf and on another
leaf, request/reply across a hub cluster, stream and service import
loops with a single hub, a named hub cluster and an unnamed hub cluster,
and bridging between two distinct hubs.

Behavior change: a hub without a cluster name advertises an empty name
to its leafs, even when it is clustered, so the leaf can't tell its
connections to that hub apart from connections to other hubs. It
therefore treats an empty name as the same hub. As a result, a client on
a standalone or unnamed hub can no longer reach another account on that
hub through an import that exists only on a leaf. Named hub clusters
already behaved this way. Leafs that connect to two different named hubs
can still bridge them through local imports.

70478 of 87888 relevant lines covered (80.19%)

305056.68 hits per line

Coverage Regressions

Lines Coverage ∆ File
258
76.41
-0.64% src/github.com/nats-io/nats-server/server/raft.go
215
90.03
0.23% src/github.com/nats-io/nats-server/server/client.go
86
89.94
-0.27% src/github.com/nats-io/nats-server/server/sublist.go
79
89.36
0.05% src/github.com/nats-io/nats-server/server/leafnode.go
18
82.04
-0.14% src/github.com/nats-io/nats-server/server/memstore.go
14
85.81
-0.13% src/github.com/nats-io/nats-server/server/stream.go
12
87.62
0.28% src/github.com/nats-io/nats-server/server/consumer.go
12
83.91
0.27% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
8
73.74
0.18% src/github.com/nats-io/nats-server/server/jetstream_api.go
7
86.29
-0.19% src/github.com/nats-io/nats-server/server/monitor.go
6
77.69
0.05% src/github.com/nats-io/nats-server/server/filestore.go
4
82.23
-0.54% src/github.com/nats-io/nats-server/server/parser.go
4
81.94
0.23% src/github.com/nats-io/nats-server/server/route.go
4
88.27
-0.14% src/github.com/nats-io/nats-server/server/server.go
2
72.73
-0.42% src/github.com/nats-io/nats-server/server/avl/seqset.go
2
63.82
0.14% src/github.com/nats-io/nats-server/server/opts.go
1
85.99
0.25% src/github.com/nats-io/nats-server/server/accounts.go
1
84.72
0.31% src/github.com/nats-io/nats-server/server/events.go
Jobs
ID Job ID Ran Files Coverage
1 37729528973.1 66
80.19
GitHub Action Run
Source Files on build 37729528973