romshark / datapages / 37697167846

52%

Build Type

push

github

Committed by romshark

Commit Message

fix: Read nested signals bound to subject fields

A page that handles an event scoped by a nested signal
never receives the event:

    // EventChatSaid is "chat.said"
    type EventChatSaid struct {
        Room datapages.Subject `signal:"chat.room"`
        Text string            `json:"text"`
    }

    func (PageChat) OnChatSaid(e EventChatSaid, sse datapages.SSE) error

    <div data-signals="{chat: {room: 'lobby'}}">

The browser opens the page's stream with {"chat":{"room":"lobby"}}.
The stream looks for the flat key "chat.room", finds nothing and
answers 400. The page retries, gets 400 again, and OnChatSaid never
runs.

Refuse a page whose events need one signal both as a value and as
an object, such as chat and chat.room. $chat.room exists only when
$chat is an object.

Coverage Stats

91 of 93 new or added lines in 3 files covered. (97.85%)

1 existing line in 1 file now uncovered.

16375 of 36929 relevant lines covered (44.34%)

582.34 hits per line