romshark / datapages / 37681311124

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: Don't panic when a stream's client is gone

A visitor who leaves a page while its stream subscribes
makes net/http log a panic with a stack trace.
Leaving a page early is normal, not a server fault. Yet every such
visit logs an error that reads like a crash that needs investigation.
The natscore broker makes this more common, because the stream waits
for a round trip to NATS before it sends its headers.

A writer that cannot flush still panics, since it breaks every stream.

Coverage Stats

9 of 13 new or added lines in 1 file covered. (69.23%)

24 existing lines in 3 files now uncovered.

16263 of 36825 relevant lines covered (44.16%)

583.47 hits per line